This implementation only covers string interpolation for SecretString type, right? But we need it for other types as well. At minimum other String as well.

We need to come up with a such abstraction that it will be easier later to add other sources of data, not only secrets but envs, for example.

This implementation only covers string interpolation for SecretString type, right?

Yes, only for SecretString

@galibey regarding the String case, I added a new method to the SecretStore trait. The method is resolve_str where you can pass any String and it will resolve it.

We need to come up with a such abstraction that it will be easier later to add other sources of data, not only secrets but envs, for example.

Maybe creating a new Wrapper type for String, were we could call SecretStore::resolve, EnvStore::resolve, and any other resolvers as needed?

@galibey regarding the String case, I added a new method to the SecretStore trait. The method is resolve_str where you can pass any String and it will resolve it.

I meant it works with yaml string only if its Rust counterpart is SecretString, not String.
And other yaml data types is not covered, but according to the linked issue, they should.

Upd. My bad, only string type is required

I meant it works with yaml string only if its Rust counterpart is SecretString, not String. And other yaml data types is not covered, but according to the linked issue, they should.

The find_secrets function will work as expected (We will be able to detect which are the secret names), but yes, we don't automatically resolve them on connector config. Do you think that we should do an automatic resolve() for every string in the input?

Maybe creating a new Wrapper type for String, were we could call SecretStore::resolve, EnvStore::resolve, and any other resolvers as needed?

Yes, this is a possible approach. The other one could be is to parse the config data into string, replace variables and then parse the resulting string into config type.

The find_secrets function will work as expected (We will be able to detect which are the secret names), but yes, we don't automatically resolve them on connector config. Do you think that we should do an automatic resolve() for every string in the input?

Could be so, yes.

Maybe creating a new Wrapper type for String, were we could call SecretStore::resolve, EnvStore::resolve, and any other resolvers as needed?

Yes, this is a possible approach. The other one could be is to parse the config data into string, replace variables and then parse the resulting string into config type.

Implemented that behavior in f6331950a1a834b32bb9bb9db0e3425c55b99a29

@sehz could you take another look?

@sehz please take another look

bors r+

Pull request successfully merged into master.

Build succeeded:

• Done